feat: handle 2fa code in new login flow [WPB-15853] #3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamilmedina
approved these changes
Feb 5, 2025
saleniuk
requested review from
a team,
sbakhtiarov,
alexandreferris,
vitorhugods,
ohassine and
mathias-niboulies
and removed request for
a team
borichellow
approved these changes
Feb 10, 2025
| NewLoginTitle("Enter your password to log in") | ||
| NewLoginTitle("Enter your password to log in") | ||
| NewLoginSubtitle("Enter your password to log in") | ||
| NewLoginSubtitle("Enter your password to log in") |
There was a problem hiding this comment.
shouldn't here be only 1 NewLoginSubtitle? 🤔
There was a problem hiding this comment.
it's just for the preview to simulate situation when there are multiple texts inside the NewLoginHeader to make sure that the navigation icon button is placed properly 😃
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
LoginStateNavigationAndDialogs)Testing
Test Coverage (Optional)
How to Test
Build
devDebugvariant, switch to backend with 2FA enabled, log in and enter 2FA code.Attachments (Optional)
newlogin-2facode.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.